marcardar / transcriptstudio-isha

Automatically exported from code.google.com/p/transcriptstudio4isha
0 stars 0 forks source link

ConceptManager and CategoryManager issues when session not saved #79

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create new concept via concept manager
2. Create new markup and assign additional concept of the same name
3. Rename concept via concept manager
4. Save
5. Reload from database

What is the expected output? What do you see instead?
I expect to see the additional concepts renamed with the new name, but they
are unchanged.

Please use labels and text to provide additional information.

Original issue reported on code.google.com by swami.ke...@gmail.com on 22 Mar 2009 at 3:19

GoogleCodeExporter commented 9 years ago

Original comment by mjc1...@gmail.com on 2 Apr 2009 at 3:45

GoogleCodeExporter commented 9 years ago
To clarify...

Renaming concepts does rename additional concepts in the database.

The problem is that it does not rename additional concepts in the current open
transcript which have not yet been saved.

Also, when returning from the concept manager, we do not refresh the transcript 
page
- so any changes to concept names are not immediately seen (workaround is to 
reload).

I suggest the following:

1. When the user goes to either the concept or category manager, insist they 
save the
transcript (assuming there are unsaved changes

2. When returning from the manager, reload the transcript.

Is this acceptable?

Original comment by mjc1...@gmail.com on 6 Apr 2009 at 3:32

GoogleCodeExporter commented 9 years ago
Fixed in r

Before going to Concept/CategoryManager (via Admin menu), the user is now 
prompted
what to do with unsaved changes. After coming out of the manager the session is 
reloaded.

This is for safety even though normally a refresh of the view would be enough.

Here are the scenarios:

Category Mgr:
1a) Add: no problem - no need to even refresh the view after closing the manager
1b) Edit: need to refresh the transcript (changes to cat name and concepts, 
potentiallt)
1c) Remove: possible that a category is deleted but is still referenced by the
current unsaved session

Concept Mgr:
2a) Add: potentially a problem if an unsaved additional concept normalizes to 
same name
2b) Edit: need to refresh transcript after dialog closes
2c) Remove: need to refresh. But also if the concept removed is also an 
additional
concept (not yet saved to db) then this concept will reappear when session is 
saved.

To make things simple, we just insist the user saves the session before 
continuing to
the manager. Closing the manager forces a reload of the session. This is a 
little
overkill but OK.

When the user accesses the Category Manager via the Markup Properties Pane, the
remove is disabled. Coming out of this pane refreshes the whole transcript pane.

1. The user deletes a category which has just been assigned to the unsaved 
session
2. 

Original comment by mjc1...@gmail.com on 7 Apr 2009 at 5:46

GoogleCodeExporter commented 9 years ago

Original comment by mjc1...@gmail.com on 7 Apr 2009 at 5:50