improve performance - Githubissues

marcbachmann / node-html-pdf

This repo isn't maintained anymore as phantomjs got dreprecated a long time ago. Please migrate to headless chrome/puppeteer.

MIT License

3.56k stars 543 forks source link

improve performance #109

Open alonagar opened 8 years ago

alonagar commented 8 years ago

for each PDF you are spawning a new phantom.js child process. is it possible to reuse the same process to create multiple PDFs, instead of killing it and reloading it for every PDF?

This will speedup the io and less CPU usage...

ryanhaugh commented 8 years ago

+1 Some good resources:

http://www.feedhenry.com/server-side-pdf-generation-node-js/ (they talk about what they did to use the same phantom instance
https://github.com/amir20/phantomjs-node (source code that shows how to do it)

SystemParadox commented 8 years ago

Also useful: phridge, which I was using to do this manually until I replaced it with html-pdf for simplicity. Would be nice to do something similar here.

neumartin commented 4 years ago

Hi!, any update of this?

SystemParadox commented 4 years ago

PhantomJS has been officially deprecated. I would strongly recommend using puppeteer for this now. It's pretty straightforward.