search

marcbachmann / node-html-pdf

This repo isn't maintained anymore as phantomjs got dreprecated a long time ago. Please migrate to headless chrome/puppeteer.
MIT License
3.56k stars 543 forks source link

`base` option must end in a slash? #149

Open shakvaal opened 8 years ago

shakvaal commented 8 years ago

I tried using a base path without trailing slash and it just doesn't work - my resourses won't load unless I add one.

Is it a bug, an undocumented feature or am I doing everything wrong?

Prinzhorn commented 8 years ago

Same here. Wondered why image wasn't loading, thanks for the hint @shakvaal

Also it doesn't seem to work for header/footer option at all. Need to use the absolute file:// path.

lekhnath commented 8 years ago

Same here too, path option requires trailing slash to function properly.