search

marcbachmann / node-html-pdf

This repo isn't maintained anymore as phantomjs got dreprecated a long time ago. Please migrate to headless chrome/puppeteer.
MIT License
3.56k stars 545 forks source link

Dependency update #600

Closed abdulkalam1233 closed 3 years ago

FelipeBarrosCruz commented 3 years ago

Please, merge this PR. It's fix security issue.

abdulkalam1233 commented 3 years ago

Can Any body fix the deprecated package issue.

marcbachmann commented 3 years ago

This is not really a security issue as it's only the devDependencies and the code wasn't adopted to the new standard convention in here. It needs some more work and an official breaking change (var -> const -> drop older node versions).