style: fix new `standard` linting

marcbachmann / node-html-pdf

This repo isn't maintained anymore as phantomjs got dreprecated a long time ago. Please migrate to headless chrome/puppeteer.

MIT License

3.56k stars 545 forks source link

style: fix new `standard` linting #657

Closed theoludwig closed 2 years ago

theoludwig commented 2 years ago

This PR update standard to the next version (v17) coming soon and fixes linting issues (using standard --fix). This allows having the test-external of standard passing for marcbachmann/node-html-pdf, before releasing to stable, we ensure that the ecosystem can easily upgrade without issues.

This new version includes:

object-shorthand rule (as warning)
Support for ESLint v8
--verbose by default

theoludwig commented 2 years ago

This PR has no recent activity, and probably won't be merged for a long time and as I don't want/have time to do the job for this PR, I decided to close it.

Feel free to open another PR yourself based on this one if you want this to be implemented.