search

marcboeker / go-duckdb

go-duckdb provides a database/sql driver for the DuckDB database engine.
MIT License
623 stars 97 forks source link

Missing include for latest version of duckdb #158

Closed taniabogatsch closed 6 months ago

taniabogatsch commented 6 months ago

DuckDB's cutting-edge version removed stdlib from the C API header file here.

This also means that go-duckdb currently does not compile with the latest version of DuckDB.

@marcboeker, the next time you deploy this driver, I expect it to fail with compiler errors such as: could not determine kind of name for C.free. A possible fix is to include it manually in the necessary files.

/*
#include <duckdb.h>
#include <stdlib.h>
*/
import "C"
marcboeker commented 6 months ago

Thanks for the info. I think we can prepare a version that includes the stdlib.h with the next version upgrade of DuckDB once it's released.

taniabogatsch commented 6 months ago

Fixed in #163.