Fix TIMESTAMP_TZ issue in 0.10.0

marcboeker / go-duckdb

go-duckdb provides a database/sql driver for the DuckDB database engine.

MIT License

623 stars 97 forks source link

Fix TIMESTAMP_TZ issue in 0.10.0 #181

Closed niger-prequel closed 5 months ago

niger-prequel commented 5 months ago

Fixes #172

Completed

[x] Update duckdb.h
[x] Include serialization for DUCKDB_TYPE_TIMESTAMP_TZ

Notes

There may be other types that need similar treatment like DUCKDB_TYPE_TIME_TZ. I only addressed what was blocking functionality for Prequel
I believe this only works against the HEAD of main for DuckDB and not the v0.10.0 tag.

taniabogatsch commented 5 months ago

Updating the header will happen after DuckDB's next bug-fix release, as go-duckdb does not build cutting-edge binaries. From my understanding, the current header already includes the TIMESTAMPTZ, so the fix should work without the header changes.

niger-prequel commented 5 months ago

@taniabogatsch reverted the header change.

marcboeker commented 5 months ago

@niger-prequel Thanks for the PR. I think we can close this in favor of #180? cc @taniabogatsch