search

marcbradshaw / mail-dkim

Mail::DKIM Perl module, forked from svn://svn.code.sf.net/p/dkimproxy/code/Mail-DKIM/trunk
0 stars 13 forks source link

Corrects the $self->{result_reason} variable name for $self->{details… #3

Closed damienmascre closed 4 years ago

damienmascre commented 4 years ago

Hi, the Mail::DKIM::ARC::Signer.pm module logs the details for the result in $self->{result_reason} whereas the Mail::DKIM::Common.pm uses the $self->{details} to generate the output for the $self->result_detail() method, so the ARC module output does not say why it failed or skipped the verification/sealing. I corrected the ARC::Signer.pm to use the correct variable name.

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 78.716% when pulling f98196ea7310cd4c61e003399f24dd116fb5cd96 on damienmascre:master into 9a3b50752e1b27a434ce9de5862d492cd31efbce on marcbradshaw:master.

marcbradshaw commented 4 years ago

Thanks for the pull request, this seems reasonable.