search

marccanby / linguiphyr

Linguistic Phylogenetic Analysis in R
Apache License 2.0
2 stars 0 forks source link

Review for JOSS #15

Closed fauxneticien closed 5 months ago

fauxneticien commented 7 months ago

Hi @marccanby —

Just completing my review for JOSS. Looks like Simon's review has covered quite a bit already so just some minor notes in a single issue:

  1. Permissions may not be sufficient Screenshot 2024-03-05 at 4 22 16 PM

I ran into the "Open a Mac app from an unidentified developer" issue when I went to click "Run PAUP*" later. You might want to specify people to right click and open the paup executable here to trigger the Open a Mac app from an unidentified developer warning here after installation, so R can call it later down the line.

  1. Image broken in README:
Screenshot 2024-03-05 at 4 20 53 PM
marccanby commented 5 months ago

Thanks for the great advice! I have taken care of both of these points, so I am closing the issue.