marcdacz / compare-pdf

Standalone node module that compares pdfs
MIT License
62 stars 21 forks source link

Fix for ImageMagick 7+ #32

Closed humphreyn closed 1 year ago

humphreyn commented 1 year ago

fixes #29

Requires ImageMagick 7+

Enables the use of any of the following image engines:

Enables setting of optional password for password encrypted or restricted PDF's. Added new tests for password encrypted and password restricted PDF's

Tested against:

humphreyn commented 1 year ago

Hi @marcdacz, sorry for the delay I have removed the linting and supplied a fix for using ImageMagick 7+.

You can also now use a password for encrypted pdf files and any of the image engines

marcdacz commented 1 year ago

thanks for raising the PR mate. would it be too much if I ask you to split this into 2? since it also includes the password option as well.

humphreyn commented 1 year ago

@marcdacz , ok will split into two PR's

marcdacz commented 1 year ago

@humphreyn is there any update on splitting these? I will decline this for now and will wait for your next PRs

humphreyn commented 1 year ago

Hi @marcdacz , Sorry for this work has been a nightmare. I will try and get this done over the weekend