marcdotson / conjoint-ensembles

Using clever randomization and ensembling strategies to accommodate multiple data pathologies in conjoint studies.
MIT License
0 stars 1 forks source link

QOL improvements #61

Closed marcdotson closed 3 years ago

marcdotson commented 3 years ago

This smooths over some of the rough edges and provides needed quality-of-life improvements after merging the previous three branches, including:

marcdotson commented 3 years ago

FYI, @RogerOverNOut there was one mistake in predictive_fit_hmnl() that I believe I fixed correctly. The function was still referencing Umat_gammadraws, but looking back at the previous version of the function it looks like that was all changed to Umat when we went to posterior parameter means only. The change is implemented with the old lines of code commented out.

RogerOverNOut commented 3 years ago

Nice catch! that would all be correct.

On Wed, Feb 17, 2021 at 3:08 AM Marc Dotson notifications@github.com wrote:

FYI, @RogerOverNOut https://github.com/RogerOverNOut there was one mistake in predictive_fit_hmnl() that I believe I fixed correctly. The function was still referencing Umat_gammadraws, but looking back at the previous version of the function it looks like that was all changed to Umat when we went to posterior parameter means only. The change is implemented with the old lines of code commented out.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marcdotson/conjoint-ensembles/pull/61#issuecomment-780381233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHEP55D24F3VFEXB2U6IJLTS7N2PRANCNFSM4XXUGFNQ .