Closed marcdotson closed 3 years ago
FYI, @RogerOverNOut there was one mistake in predictive_fit_hmnl()
that I believe I fixed correctly. The function was still referencing Umat_gammadraws
, but looking back at the previous version of the function it looks like that was all changed to Umat
when we went to posterior parameter means only. The change is implemented with the old lines of code commented out.
Nice catch! that would all be correct.
On Wed, Feb 17, 2021 at 3:08 AM Marc Dotson notifications@github.com wrote:
FYI, @RogerOverNOut https://github.com/RogerOverNOut there was one mistake in predictive_fit_hmnl() that I believe I fixed correctly. The function was still referencing Umat_gammadraws, but looking back at the previous version of the function it looks like that was all changed to Umat when we went to posterior parameter means only. The change is implemented with the old lines of code commented out.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/marcdotson/conjoint-ensembles/pull/61#issuecomment-780381233, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHEP55D24F3VFEXB2U6IJLTS7N2PRANCNFSM4XXUGFNQ .
This smooths over some of the rough edges and provides needed quality-of-life improvements after merging the previous three branches, including:
01_control-file.R
.02_data-prep.R
.nmember
in the control file and easily run it without inadvertently mixing up simulated data files or re-running what we don't need to re-run.ensemble-fit
file for a given simulated data andnmember
with an updated naming scheme that matches data.ensemble-fit
.ensemble-fit
object for the given simulated data andnmember
.