marcel-licence / ML_SynthTools

ML_SynthTools
GNU General Public License v3.0
131 stars 20 forks source link

to trully fix ESP32S3 I2S interface... #45

Open matixan opened 2 months ago

matixan commented 2 months ago

Here are some not usual #ifdef https://github.com/marcel-licence/ML_SynthTools/blob/3b8cf78d514c704e08a32ad8390be5deb5457ff1/src/i2s_interface.h#L505-L507 change these to

#ifdef ARDUINO_RUNNING_CORE
#ifndef CONFIG_IDF_TARGET_ESP32S3
    .mck_io_num = I2S_PIN_NO_CHANGE,
#else
    .mck_io_num = I2S_MCLK_PIN,
#endif
#endif

Also https://github.com/marcel-licence/ML_SynthTools/blob/3b8cf78d514c704e08a32ad8390be5deb5457ff1/src/i2s_interface.h#L531-L536


    #ifndef CONFIG_IDF_TARGET_ESP32S3
    REG_WRITE(PIN_CTRL, 0xFFFFFFF0);
    PIN_FUNC_SELECT(PERIPHS_IO_MUX_GPIO0_U, FUNC_GPIO0_CLK_OUT1);
    #endif
matixan commented 2 months ago

Bump

CommentedNewline commented 5 days ago

Why not write a PR?