search

marcel-licence / esp32_basic_synth

ESP32 based simple synthesizer project
GNU General Public License v3.0
245 stars 38 forks source link

Using Core0 #57

Closed MichaelPNolan closed 3 years ago

MichaelPNolan commented 3 years ago

I moved some processing to the Core0 task loop

At first it wasn't being called but I checked your code and it was updated to the MIDI_VIA_USB... module so adding that in now it works.

#if (defined ADC_TO_MIDI_ENABLED) || (defined MIDI_VIA_USB_ENABLED)
    xTaskCreatePinnedToCore(Core0Task, "Core0Task", 8000, NULL, 999, &Core0TaskHnd, 0);
#endif

In the first 30-60 seconds I get audio glitches - even one where it was making a rough popping on left side then right side alternating. So processing Core0 seems to slow auto processing which we assume only happens on Core1 in arduino. Therefore, generally no improvement - but over time things seem to buffer or perform ok. So I'll look at having a kind of reduced frequency of calls in the Task0loop using some kind of loop count variable to see if that removes that glitch.

marcel-licence commented 3 years ago

Do you run your own version actually or the latest, original code from GitHub?

MichaelPNolan commented 3 years ago

I guess it's my own version at this point. So I'd have to map all my changes to upgrade. Not that many changes, trying to use per design. Mostly add ons.

Regards Michael

On Mon, Jul 19, 2021, 01:22 Marcel @.***> wrote:

Do you run your own version actually or the latest, original code from GitHub?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marcel-licence/esp32_basic_synth/issues/57#issuecomment-882098279, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTDOQ74Z2YIG52MFTBYHSLTYMLW5ANCNFSM5ASIWFVA .

marcel-licence commented 3 years ago

Hm okay when there are modifications then it would be very hard to support. I would like to convert this issue into a discussion then.

MichaelPNolan commented 3 years ago

Ok - you made me realize that. However, i was just surprised since I was doing it all without Core0Task and then I got ... less performance by using it? So that part ... is more like an issue but its not shared software. Was just thinking you might have tips or have experienced same along the way. Please convert. Regards Michael

On Mon, Jul 19, 2021 at 11:22 PM Marcel @.***> wrote:

Hm okay when there are modifications then it would be very hard to support. I would like to convert this issue into a discussion then.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marcel-licence/esp32_basic_synth/issues/57#issuecomment-882683074, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALTDOQ7UJO66YKYLFNL3Z43TYRGMBANCNFSM5ASIWFVA .