search

marcel / aws-s3

AWS-S3 is a Ruby implementation of Amazon's S3 REST API
http://amazon.rubyforge.org
MIT License
774 stars 461 forks source link

OpenSSL::Digest::Digest is deprecated; use OpenSSL::Digest instead #93

Closed pelargir closed 10 years ago

pelargir commented 10 years ago

This fixes issue #91 by replacing OpenSSL::Digest::Digest (which is deprecated and produces a warning in Ruby 2.1.0) with OpenSSL::Digest

marcel commented 10 years ago

Thanks for the pull request.

When was OpenSSL::Digest.new introduced? My concern with this change is versions of ruby that don't yet have it will fail here. Could you just wrap it in a respond_to? check?

pelargir commented 10 years ago

OpenSSL::Digest has been available since 1.8.7. I've added the respond_to? check.

marcel commented 10 years ago

Thanks Matthew.

jeffbyrnes commented 10 years ago

Any chance a new release could be cut to ship this?

ptoomey3 commented 10 years ago

yup...a new release would be much appreciated. Thanks!

obromios commented 10 years ago

I too would appreciate a new release, or failing that, if it is easy to do, instructions on how to clone and build my own version of the gem locally.

jhubert commented 9 years ago

:+1: new version would be great.

ghost commented 9 years ago

It is close to 3 months since this has been merged to master, please consider releasing a new version

newtonianb commented 9 years ago

Still have this issue