marcel0ll / CustomItems

The most simple way to add your custom items to minecraft
https://marcel0ll.github.io/CustomItems/
20 stars 19 forks source link

Fluids do not render properly #16

Closed Yulife closed 9 years ago

Yulife commented 9 years ago

2015-01-01_14 10 31 Fluids that got added via CustomItems are not properly rendered in specific tanks.

Seared Tank (Tinkers' Construct): Renders as Water

Ender Tank (Ender Storage): Renders as Missing Texture

Heat Resistant Tank (Mariculture): Renders properly, surprisingly.

Tank (Buildcraft): Renders as Missing Texture

Tank (OpenBlocks): Renders as Missing Texture

Fluid Tanks (EnderIO): Doesn't even render, is invisible

Portable Tank(s) (Thermal Expansion): Renders as Lava

marcel0ll commented 9 years ago

I will look into it, should be fixed in the near future. Probably next version

Yulife commented 9 years ago

Just discovered that it doesn't show properly in NEI either. Smeltery Fluid Transposer Also you can see that the bucket doesn't render properly either in the Fluid Transposer.

Atraxi commented 9 years ago

I think all of these are the same cause - the Fluid icons aren't being set, with Fluid acting essentially as the Item form of BlockFluids (This causes the Fluid to search for textures in /items rather than /blocks, even though in practically every scenario you want them to be the same, the best option I found was to point it to the already registered BlockFluid textures).

I've just started a small mod of my own and fixed this a couple days ago, feel free to use mine as an example: https://github.com/Atraxi/PandemiCraft/blob/master/src/main/java/eviltalkingpie/pandemicraft/proxy/ClientProxy.java

marcel0ll commented 9 years ago

Thanks Atraxi. I dont think you have to use proxy for that. I have looked at TC and its slime fluid block it sets the fluid IIcons.

I changed my code to do the "same", and now it works fine for the mods I tested

Also, Thx Yulife for the detailed report