marcelGoerentz / Threadfin

MIT License
3 stars 1 forks source link

Could you sync working changes from official repository? #14

Closed PilaScat closed 1 month ago

PilaScat commented 1 month ago

I thought it was dead

marcelGoerentz commented 1 month ago

I will check what has been changed and sync where possible.

PilaScat commented 1 month ago

Thanks, best of both worlds ahah

marcelGoerentz commented 1 month ago

Hey, there will be a new beta in a few minutes!

PilaScat commented 1 month ago

news?

marcelGoerentz commented 1 month ago

In beta everything should be synced. I‘m currently working on the enhancement. When everything is working as expected I will push a new release.

PilaScat commented 1 month ago

Didn't saw the release, I have this bug: image

marcelGoerentz commented 1 month ago

Seems like the muxer does not like the argument. Do you now the codecs of the stream?

PilaScat commented 1 month ago

he does it with everyone, anyway .m3u8 edit: wait for the codecs, everyone is different, but none works image I think there's an error when passing the string to ffmpeg

marcelGoerentz commented 1 month ago

I also think there is an error, this was introduced with the new functions I‘ve synced.

PilaScat commented 1 month ago

Be aware in another bug with the original project, the counter of active streams is broken

marcelGoerentz commented 1 month ago

I also think there is an error, this was introduced with the new functions I‘ve synced.

I found the error to this and it will be fixed in next beta! There was a typo in the arguments for ffmpeg.

Be aware in another bug with the original project, the counter of active streams is broken

Can you explain what exactly is broken so I can have a deeper look into it?

PilaScat commented 1 month ago

Be aware in another bug with the original project, the counter of active streams is broken

Can you explain what exactly is broken so I can have a deeper look into it?

It counts backwards 😂

There's another problem, streams doesn't work at all image image Probabilbly is about the ip, it need to be the external, not the internal one, like 192.168.1.20 instead Even though it worked like this before anyway

marcelGoerentz commented 1 month ago

Good hint I will take a look at it.

marcelGoerentz commented 1 month ago

Latest beta build should work now!

PilaScat commented 1 month ago

ill try now

PilaScat commented 1 month ago

image same problem

marcelGoerentz commented 1 month ago

Are you sure you are using the latest beta? This options are not existing anymore.

PilaScat commented 1 month ago

Are you sure you are using the latest beta? This options are not existing anymore.

Sorry, it was cached, updated with Threadfin:beta docker image but it tells this image It works but I don't know if I'm testing the beta, the counter disappeared

marcelGoerentz commented 1 month ago

This is the main branch 😟 Maybe I need to check my Docker container

marcelGoerentz commented 1 month ago

Version should be 1.2 Build 4-beta

PilaScat commented 1 month ago

and probably in the 1.2.3 version there was a memory leak, I forgot to tell you 😂 if it happens again with the new version I'll tell you, it made my entire server crash for a day ahha

PilaScat commented 1 month ago

Version should be 1.2 Build 4-beta

maybe it's because you went back in version from what I saw in the commit

marcelGoerentz commented 1 month ago

Could be but should not be 🥲

marcelGoerentz commented 1 month ago

Okay, the error is in my Dockerfile 😢 I need to check how I can fix it

marcelGoerentz commented 1 month ago

Okay next beta release should be working!

marcelGoerentz commented 1 month ago

Sorry there is an issue with the beta release yaml file also.

PilaScat commented 1 month ago

I'll wait, tell me when its ready

marcelGoerentz commented 1 month ago

I'll wait, tell me when its ready

Sorry for the circumstances... The next beta release should really fix everything 😄

PilaScat commented 1 month ago

No problem

PilaScat commented 1 month ago

image why it says this ip? unreachable from plex, but reachable from webui at 192.168.1.20:34400 fixed setting via threadfin domain, but it shouldn't be necessary

marcelGoerentz commented 1 month ago

Well Threadfin takes the first IP it finds. Running in a docker container it will take the containers IP. Defining the domain will make it accessible from outside the docker container with the correct FQDN or IP. I will fix this in docu / tool tip as soon as possible!

marcelGoerentz commented 1 month ago

By said this, it is necessary to set the domain for Docker users Nevertheless, if the listening IP option hasn't been used the Threadfin will be reachable over the host interface with the given port.

PilaScat commented 1 month ago

Well Threadfin takes the first IP it finds. Running in a docker container it will take the containers IP. Defining the domain will make it accessible from outside the docker container with the correct FQDN or IP. I will fix this in docu / tool tip as soon as possible!

I know but in reality his ip in the docker network is 172.18.0.xx I don't know where he found the 10.5.0.2 ahhaha

anyway fixed this seems perfect, I'll try to keep it open for some hours to test stability

marcelGoerentz commented 1 month ago

I don't know where he found the 10.5.0.2 ahhaha

Me neither 🤣

PilaScat commented 1 month ago

anyway in my opinion it is already stable for main branch

marcelGoerentz commented 1 month ago

Great to hear! I will push it to main tonight. I already have another feature ready that will store the created PIDs and kill all processes that have been left at the next start of the software! This will be pushed to beta afterward. Then I will begin with the customization No more streams thing :)

PilaScat commented 1 month ago

perfect