search

marceldev89 / BattleNET

BattlEye Protocol Library and Client
GNU Lesser General Public License v3.0
76 stars 44 forks source link

raising threads as background - to kill thread if main app is closed #44

Closed tym32167 closed 6 years ago

tym32167 commented 6 years ago

Think it is better to create only background threads

marceldev89 commented 6 years ago

I guess this makes sense, thank you. Can't test this but I doubt it'll have any bad side effects. :)

tym32167 commented 6 years ago

@marceldev89 dont worry, my users will test it. Btw, do you have plans to port it to .net core 2 or .net standart? I ported it to .net core 2 and it is working fine.

marceldev89 commented 6 years ago

This is basically unmaintained as far as I'm concerned. If the BattlEye protocol ever changes and this needs an update then I'll probably do that but beyond that it won't see much work from me.

If porting to .NET Core 2 doesn't break compatibility with "regular" .NET (which it probably doesn't) then feel free to PR that as well.