Closed mlof closed 5 years ago
Why do 3 party library should care about client stuff like encoding? This is ASP.NET core issue, not .NET starndard. Lets client to decide how to handle encoding issues. Battlenet - made as Standard 2.0 library and it can be used not only with Asp.NET core 2. Moreover, setting encoding in BattleyeClient class? This is not a purpose to do things like that. If you have asp.net core app - please, setup encoding inside Startup class and dont mix this with Battleye code. Voting to reject this PR and close.
I agree with @tym32167.
I keep mistaking the differences between all the .NET versions these days.. Haven't been in the .NET realm for a while now and assumed it might have broken something somewhere. But I agree, this is probably not a job for the library. Thanks for the effort though. :heart:
https://github.com/marceldev89/BattleNET/pull/47#issuecomment-467061459
I agree with @tym32167.
He's alive! :smiley:
Thank you. Is the library broken without this change?