search

marcelja / facebook-delete

Fast facebook activity deletion
MIT License
1.28k stars 48 forks source link

increase default rate limit to prevent quick lockouts #55

Closed nyghtly-derek closed 1 year ago

nyghtly-derek commented 1 year ago

The default rate limit is too fast, and results in a lockout very quickly. I think that it would be better to set the default timeout to be longer, so that users don't get locked out right away. Users can then ratchet down the timeout on their own if they want to.

I changed it to 1000ms, which is just a guess. It would take quite a long time to figure out the optimal wait time, because the only way to test it is by getting locked out, and then waiting until you're unlocked to try something else.

marcelja commented 1 year ago

I don't think that I would like to have such a high default delay. It will take extremely long to delete many elements with that.

nyghtly-derek commented 1 year ago

Yes, it's very slow. However, we don't have much of a choice in the matter. From my testing so far, Facebook is very agressive with their rate limit. I tried it with 1000ms, and I got locked out before getting through searching the first year of data.

I assume that most users want to use this one time so that they can delete all or most of their data, in which case leaving it to run over night doesn't seem so bad.

Not sure what else to do, unless someone has some special knowledge on how we can defeat the rate limit.

nyghtly-derek commented 1 year ago

I'm going to close this since there's not much interest in changing the timeout. I was able to use my fork to delete all of my facebook data, but it took a few days to finish.