marceljuenemann / angular-drag-and-drop-lists

Angular directives for sorting nested lists using the HTML5 Drag & Drop API
MIT License
2.16k stars 713 forks source link

Error thrown when using Shim #399

Open Azsael opened 7 years ago

Azsael commented 7 years ago

I have added https://github.com/timruffles/ios-html5-drag-drop-shim shim before drag and drop library enabled.

However when a drag event occurs the event.dataTransfer.effectAllowed is undefined which is causing a cascade failure.

I have fixed this locally by changing the function function getDropEffect(event, ignoreDataTransfer)

to be this

effects = filterEffects(effects, event.dataTransfer.effectAllowed || dndState.effectAllowed);

But not sure if this would be something supported or not.

Should I create a PR back?

WulffHunter commented 7 years ago

I'm getting the same error, and it's preventing me from using the minified document. Anyone know a fix for the min?