search

marcelklehr / smokesignal

Build your own small (or larger) peer to peer network with node.js
154 stars 21 forks source link

Not actually calling `isSufficientlyFilled` #16

Closed jabr closed 8 years ago

jabr commented 8 years ago

It looks like this line is wrong:

https://github.com/marcelklehr/smokesignal/blob/develop/lib/node.js#L140

if(!this.peers.isSufficientlyFilled) {

It looks like that should be:

if(!this.peers.isSufficientlyFilled()) {
marcelklehr commented 8 years ago

Yes, indeed. Nice catch!

jabr commented 8 years ago

I'll send you a PR.