search

marcelklehr / smokesignal

Build your own small (or larger) peer to peer network with node.js
154 stars 21 forks source link

Added logLevel configuration option #6

Closed csicar closed 11 years ago

csicar commented 11 years ago

I like the library a lot, but it's hard to see you own debug messages when there are those from smokesignal popping up all the time. I added a few lines of code, that add a configuration option to the node({config}), that will just call the default log4js.setLevel method and change it to the chosen one. I don't know if that is what you ment in your README.md@TODO but I think that would be a nice addition for the tool. The feature is added in the :master-branch, but missing in the develop-branch, I saw that other stuff changed too, to I assume this could help you with the futher development of the tool

marcelklehr commented 11 years ago

Hey, cool. I actually meant to completely remove log4js as a dependency, though, and allow people to choose their own logging solution. (see https://github.com/marcelklehr/smokesignal/commit/2e7d9e3fc6b22f8b3b64249cc782b3ef1078c3e7)

The master branch is pretty old and didn't allow me to do things I'd like to do, so I reimplemented the whole thing in develop, using nssocket. I've also added more docs just now.

Also, I'd like to see your contributions and ideas! :)