search

marcelklehr / socialcalc

Web-based spreadsheet editor with support for real-time collaboration
Other
17 stars 23 forks source link

[Proposal] Replace icons with fontawesome #19

Open ramezrafla opened 7 years ago

ramezrafla commented 7 years ago

Upon further thinking, we could replace almost all icons with fontawesome icons (included in Bootstrap by default). We use Semantic-UI, all icons are here: http://semantic-ui.com/elements/icon.html (main page: http://fontawesome.io/)

I can see that the project aims to be framework-agnostic, so the fontawesome font could be included by default (which will be faster to load than the images folder, will look pixel-perfect and allows scaling, e.g. people with disability)

We are looking into porting into Semantic-UI (which means an extra CSS / JS) which also leverages jQuery. Imagine if all the buttons looked like this: http://semantic-ui.com/elements/button.html

If you want to try it out, just include the css / js from this repo: https://github.com/Semantic-Org/Semantic-UI-CSS

marcelklehr commented 7 years ago

I think switching to fontawesome is probably a good move, iff all the icons have an equivalent in fontawesome's collection.

Switching to a UI framework should be possible, I'm not sure if it's worth the time necessary to do that, though. However, it would probably entail a drastic modernization of the code base, which is good, imho.

eddyparkinson commented 7 years ago

fontawesome

faster to load ... allows scaling, e.g. people with disability

I like the idea, is it possible to add new icons? Things like hide column, insert row?

old icons also marcelklehr/socialcalc has older icons. ethercalc has Icons from Libreoffice. which I think look better. https://github.com/audreyt/ethercalc/commit/40eae21529d6782639f57c640ae7bf0ae9a09e80

ramezrafla commented 7 years ago

You can also create your own font https://icomoon.io/app/#/select