search

marcelklehr / socialcalc

Web-based spreadsheet editor with support for real-time collaboration
Other
17 stars 23 forks source link

Use native tooltips to improve accessibility #29

Closed tintou closed 6 years ago

tintou commented 6 years ago

Tested in Ethercalc with french locale. I also use a tiny html file testing socialcalc only.

marcelklehr commented 6 years ago

Wow, what a waste of code. :+1:

@eddyparkinson @audreyt What do you think?

audreyt commented 6 years ago

This changes the localized tooltips "Drag to lock pane vertically" and "Drag to lock pane horizontally" to the constant paneslider?

marcelklehr commented 6 years ago

Oh, I forgot about localization. Will l10n still work with this?

tintou commented 6 years ago

Oh, right, this one had a wrapper function that I just replaced with a small condition

eddyparkinson commented 6 years ago

@tintou Please add a summary of what has been tested.

I don't know this part of the code, I have never changed tool tips. As long as it has been tested and code reviewed, I am fine for it to be merged in.

tintou commented 6 years ago

I've tested it in ethercalc with the french locale, everything seems to work as expected.

eddyparkinson commented 6 years ago

will merge - native tooltips look to have been added to HTML 4.01 in 2002. So expect it will work on 99% of browsers.