search

marcelklehr / socialcalc

Web-based spreadsheet editor with support for real-time collaboration
Other
17 stars 23 forks source link

Modify drag'n fill command behaviour to fix audreyt/ethercalc#769. #52

Open herve0742 opened 2 years ago

herve0742 commented 2 years ago

Hello, With this pull request I address two points :

Drag'n fill

I think I fix this issue : audreyt/ethercalc#769 by modifying the fillright and filldown command string to embed the increment amount. My tests consists of running an ethercalc instance and using the fill command in all directions with one, two or more cells first selected. It seems to me that this is good.

Gulp

I also update gulp package from 3 to 4, to use with newer nodejs. So I had to adapt gulp.js. This don't resolve the large warning flow nor the error as on master branch.

marcelklehr commented 2 years ago

I can't test this atm, so defer to @eddyparkinson's judgement :)