search

marcelklehr / vdom-virtualize

Virtualize a DOM node
MIT License
131 stars 27 forks source link

Dataset attributes should be added as normal attributes #11

Closed wesleytodd closed 9 years ago

wesleytodd commented 10 years ago

https://github.com/Matt-Esch/vdom/pull/14#issuecomment-60799003

As said in the above issue, it might be better to change this section to use attributes even though they are actually dataset values. Any thoughts on this?

marcelklehr commented 9 years ago

I've finally been able to consider this and have reached a verdict: Accepted! ;)

wesleytodd commented 9 years ago

Ha, well cool! Although I gave up with virtual-dom for the time being in our production app. I am still interested in the project because it would be good to have lower level virtual dom components, rather than just being stuck with React :)