search

marcelklehr / vdom-virtualize

Virtualize a DOM node
MIT License
131 stars 27 forks source link

properly handle attributes instead of deleting them #17

Closed jesseditson closed 9 years ago

jesseditson commented 9 years ago

adds support for attribtues on a dom node so they will be correctly converted to vdom attributes.

marcelklehr commented 9 years ago

Does this work the other way 'round? e.g. if you render the resulting vnode, does it have those attributes set?

marcelklehr commented 9 years ago

It does work! https://github.com/Matt-Esch/virtual-dom/blob/master/vdom/apply-properties.js#L57

marcelklehr commented 9 years ago

Thank you!

jesseditson commented 9 years ago

Ah, sorry about dragging my feet on testing that, thanks for the merge!

— Sent from Mailbox

On Mon, Jun 8, 2015 at 8:10 AM, Marcel Klehr notifications@github.com wrote:

Thank you!

Reply to this email directly or view it on GitHub: https://github.com/marcelklehr/vdom-virtualize/pull/17#issuecomment-110032189