search

marcelklehr / vdom-virtualize

Virtualize a DOM node
MIT License
131 stars 27 forks source link

Allow vdom peerDependency updates #38

Closed timkendrick closed 9 years ago

timkendrick commented 9 years ago

This PR allows the virtual-dom peerDependency to be updated to the current version. The virtual-dom package uses semver versioning, so updating the virtual-dom dependency won't break compatibility with vdom-virtualize.

Background: a project I'm working on uses both virtual-dom and vdom-virtualize packages in separate parts of the app. Ever since I updated vdom-virtualize to 1.0.0, I've been getting dependency-hell conflicts. This is because vdom-virtualize now specifies virtual-dom as a peerDependency rather than a standard dependency, and my pre-existing virtual-dom dependency was asking for the latest version (2.1.1), whereas vdom-virtualize is now asking for a specific outdated version (2.0.1).

I'd rather not downgrade the virtual-dom package in my application, as it seems much more sensible to allow the vdom-virtualize package to use semver to allow the latest fixes to virtual-dom. I've tested vdom-virtualize with the updated virtual-dom package, and everything is working fine.

marcelklehr commented 9 years ago

Thank you for reporting

timkendrick commented 9 years ago

That's brilliant, thanks for updating the package so quickly!