search

marcello505 / godot-ggrs-wrapper

A Rust GDNative project to provide GGRS to the Godot Engine
MIT License
21 stars 1 forks source link

Example project where the library gets used inside Godot #13

Closed marcello505 closed 2 years ago

marcello505 commented 3 years ago

While i've done simple quick start guide to show how the library works, having an actual example project is probably a better way of showing the library in action.

trian-gles commented 2 years ago

I'd like to start working on this over the weekend!

marcello505 commented 2 years ago

Appreciated! Feel free to ask any questions you may have!

trian-gles commented 2 years ago

How does this look? I mostly used the README code and made it super simple. I could also implement handling for the other GGRS events, or make an actual game.

marcello505 commented 2 years ago

I've read through the code and it looks good, great job man. I'll open it up in godot tomorrow to see how it looks in action.

I could also implement handling for the other GGRS events, or make an actual game.

I think it's fine if it remains simple like this, explaining the basics is the important part here. At most the comments could be adjusted to refer to the documentation so that people can read up on it further if they want to. Could you make a pull request for this branch?

Lastly i noticed one of your projects on GitHub uses this project, if you want i could add a "used by" section to the README.MD where i could link your game. Only if you want to ofc

trian-gles commented 2 years ago

PR submitted!

A mention of my project would be great, I'll add a link back to this repo as well.

marcello505 commented 2 years ago

I've merged #15 and added a link to Girls With Sword. I also added an entry in the changelog where I've credited your addition. Thank you once again for your contribution :+1: