search

marcellodum / marlin-mingda-md-d301

Unofficial Marlin firmware for the Mingda MD D301 board used on the Rock 3, Rock 3 Pro, D2, and other printers
GNU General Public License v3.0
14 stars 9 forks source link

integration to official Marlin #10

Open atsju opened 2 years ago

atsju commented 2 years ago

you did all the great work, why didn't you do a PR to merge this to official Marlin ? It would need less support from your side after that...

Anyway, I just did the full job myself (and unfortunately discovered your repo only after that). Could you test the commit or compare with your code base ? https://github.com/atsju/Marlin/commit/68d23ab8c6e7655618b9e8a7db32b3f540af6747

atsju commented 2 years ago

I see in b0f23a61f5d9c21380faba9ca7d287c159430ff4 you rely on a "TFT_GENERIC" this is great. I would have so much questions for you. Is there any reason not to port your code/configuration to official Marlin ?