search

marcellourbani / vscode_abap_remote_fs

Remote filesystem for ABAP systems
MIT License
174 stars 28 forks source link

name of server in configuration can't contain blank/Chinese character #124

Closed hsingll closed 3 years ago

hsingll commented 4 years ago

Bug Report

Name of server in configuration can't contain blank, or a error output will display when save.

Steps to reproduce the behavior:

    "abapfs.remote": {

        "TEST 100": { "Contain blank here
            "url": "http://s4dev01.****.com:8000/",
            "username": "****",
            "password": "****",
            "client": "100",
            "language": "EN",
            "allowSelfSigned": false,
            "sapGui": {
                "server": "***.***.***.***",
                "systemNumber": "00"
            }
        }

open program file and then save. output:

Message: Request vscabap.readConfig failed with message: Cannot destructure property 'sapGui' of 't' as it is undefined.
Code: -32603
marcellourbani commented 3 years ago

Sorry for the delay, fix should come later today. Didn't try chinese character, but does work with a space and a cat face :)

    "TEST 🐱100": {
      "url": "https://localhost:50001",
      "username": "developer",
      "password": "",
      "allowSelfSigned": true,
      "client": "001",
      "sapGui": {
        "server": "localhost"
      }
    },