search

marcellourbani / vscode_abap_remote_fs

Remote filesystem for ABAP systems
MIT License
172 stars 28 forks source link

Add support for secure network communication #175

Closed pietbrauer closed 1 year ago

pietbrauer commented 2 years ago

Some of our SAP instances are must use secure network communication and I wasn't able to find a setting for it using this plugin.

I was able to get the communication working using Eclipse, so I guess it's possible without SAPGUI, but would love to use VSCode for development.

Any pointers are welcome and I am happy to submit a PR.

marcellourbani commented 2 years ago

@pietbrauer this plugin works over http(s), eclipse over RFC. secure communication is supported over https

See the wiki

pietbrauer commented 2 years ago

Yes, I uses https but it doesn't start the Secure Login Client?

marcellourbani commented 2 years ago

No idea what you're talking about: maybe some sort of single sign on? For SSO this only supports oauth bearer tokens, and I only ever tried it with my SAP cloud trial account

fabianlupa commented 2 years ago

I think it's this?

image

pietbrauer commented 2 years ago

Sorry for not getting back. Yes exactly. Once you want to login it opens the Secure Login Client Application and then opens the login window as per usual. Eclipse also launches it but I am not sure about how it works under the hood.

marcellourbani commented 2 years ago

yep that applies to RFC connections, used by Eclipse and sapgui. This plugin goes over HTTP(S) and just doesn't have that setting

pietbrauer commented 2 years ago

I understand that. So it should just work over HTTPS? I thought the server enforcing this “ultra secure connection” is the reason I am unable to connect to the servers.

marcellourbani commented 2 years ago

Hard to say where the problem is without access to your system. If you can access fiori applications with the same base URL without using a proxy you should be fine Also you'll need to activate the SICF node