marcellourbani / vscode_abap_remote_fs

Remote filesystem for ABAP systems
MIT License
170 stars 28 forks source link

Modification of newly created FM #214

Closed maggiv8 closed 4 months ago

maggiv8 commented 4 months ago

Hi Marcello

I do seem to have an issue when creating and afterwards trying to activate modificiations in a new Function Module - at least on my setup A) Steps to reproduce issue:

  1. Create Function Module Group.
  2. Create Function Module for this group (I am getting an error here as well, but the FM gets ultimately create in the backend system)
  3. Save and activate Function Module.
  4. Make changes on Function Module code level (e.g. new IF statement) and activate again.

Current result: The code changes after the initial activation cannot be seen in SAP GUI on the Function Module.

Expected result: The changes after the initial activation should be seen in SAP GUI on the Function Module.

Not sure if you are experiencing a similar or same issue. If you please could have a look at it, it would be appreciated.

Thank you. Best, C.

marcellourbani commented 4 months ago

Never happened to me, probably depends on what ABAP version you're running. What happens if you refresh the FG contents in se80? I do have some issue within the editor in these cases, and usually work around it either refreshing the function group in the tree or restarting the editor, so there's definitely something not right there

On Sat, 13 Apr 2024 at 04:44, Christoph Markert @.***> wrote:

Hi Marcello

I do seem to have an issue when creating and afterwards trying to activate modificiations in a new Function Module - at least on my setup A) Steps to reproduce issue:

  1. Create Function Module Group.
  2. Create Function Module for this group (I am getting an error here as well, but the FM gets ultimately create in the backend system)
  3. Save and activate Function Module.
  4. Make changes on Function Module code level (e.g. new IF statement) and activate again.

Current result: The code changes after the initial activation cannot be seen in SAP GUI on the Function Module.

Expected result: The changes after the initial activation should be seen in SAP GUI on the Function Module.

Not sure if you are experiencing a similar or same issue. If you please could have a look at it, it would be appreciated.

Thank you. Best, C.

— Reply to this email directly, view it on GitHub https://github.com/marcellourbani/vscode_abap_remote_fs/issues/214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASW6HK7LU6QRMBMW2LMCB3Y5CS2XAVCNFSM6AAAAABGFDXBL2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2DCMRVHAYDSNY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

maggiv8 commented 4 months ago

Hi Marcello,

I tried to refresh the content, but it doesn't really do anything. The FM always just contains the original content of the first commited version so to speak. If you want to debug it, I can give you access to the system via email.

Thank you. Best, C.

maggiv8 commented 4 months ago

I am using S4/2021 with SAP_BASIS 756, SAP_ABA 756G.

marcellourbani commented 4 months ago

Next version should fix it

maggiv8 commented 4 months ago

Awesome, thank you Marcello.