search

marcells / node-build-monitor

A Build Monitor written in Node.js, which supports several build services and can be easily extended.
https://marcells.github.io/node-build-monitor
MIT License
349 stars 168 forks source link

Monitors with failed configurations could log credentials #211

Closed nkringle closed 4 years ago

nkringle commented 4 years ago

https://github.com/marcells/node-build-monitor/blob/master/app/monitor.js#L176

As services include api credentials in their spec, when a configuration fails to load, the log statement with the configuration should either remove credentials, or have an option to disable logging for this line.

marcells commented 4 years ago

Good idea. I'll add a new flag to the configuration.

marcells commented 4 years ago

The issue is fixed. Please take a look at commit de9ced4f92f547f8b9fa41a56d8f73ad237be6a4.