search

marcells / node-build-monitor

A Build Monitor written in Node.js, which supports several build services and can be easily extended.
https://marcells.github.io/node-build-monitor
MIT License
349 stars 168 forks source link

Unit test Drone Service #219

Closed nkringle closed 4 years ago

nkringle commented 4 years ago

The drone service is not unit tested. I think this is leading to bugs. (I keep running into a scenario where when I do not include a branch or event it does not find and builds.

nkringle commented 4 years ago

If I get free time this weekend I will try to submit a PR.

nkringle commented 4 years ago

Also, I contributed to the problem with #214 as I didn't add unit tests. ;)

marcells commented 4 years ago

Thank you.