Adds Unit Tests for Drone Service & Fixes a bug in filtering

marcells / node-build-monitor

A Build Monitor written in Node.js, which supports several build services and can be easily extended.

https://marcells.github.io/node-build-monitor

MIT License

349 stars 168 forks source link

Adds Unit Tests for Drone Service & Fixes a bug in filtering #221

Closed nkringle closed 4 years ago

nkringle commented 4 years ago

Fixes #219

Primarily tests the filtering functionality. I end up testing by accident the api uri and service configuration. through the filtering tests. I'm not checking error handling (other than I don't get errors from my mocked server).

nkringle commented 4 years ago

@marcells

marcells commented 4 years ago

Thank you!

nkringle commented 4 years ago

@marcells You're welcome! I must have only run the tests in my ide and did not run the linter. 🙈 https://github.com/marcells/node-build-monitor/pull/222

nkringle commented 4 years ago

@marcells when you get a chance, could you cut a patch release with this bug fix?

marcells commented 4 years ago

Oh, didn't see your message. A release is on the way. @nkringle