search

marcells / node-build-monitor

A Build Monitor written in Node.js, which supports several build services and can be easily extended.
https://marcells.github.io/node-build-monitor
MIT License
349 stars 168 forks source link

Fix Build steps displaying incorrectly for TFS 2019 #233

Closed meeces2911 closed 3 years ago

meeces2911 commented 3 years ago

This fixes a TFS 2019 (and probably 2018) bug, where multiple build Statuses were incorrectly shown, as getLatestBuildStep wasn't correctly filtering TimelineRecords of type Task.

(For some reason Microsoft has made the TimelineRecord.Type field a String ... so I couldn't create an enum style list like the others)

This should still work for 2017, although now that we (finally) upgraded, I don't really have a way to fully test this, outside just assuming Microsoft haven't touched the version 2.0 API call in 2019.

marcells commented 3 years ago

Thank you! If we did introduce a bug, we will see how to handle it.