marcelm / cutadapt

Cutadapt removes adapter sequences from sequencing reads
https://cutadapt.readthedocs.io
MIT License
514 stars 129 forks source link

Update _kmer_finder.pyx to always use a 64-bit integer. #731

Closed rhpvorderman closed 1 year ago

marcelm commented 1 year ago

Since the only 32 bit system I had at hand was a Raspberry Pi 1, I used that for testing. After merely ~1h of compilation and further ~20 minutes that it took to run pytest (actually, multiply that by two because I tested with and without the patch), I can confirm that this seems to fix the problem. Thanks!

rhpvorderman commented 1 year ago

Another alternative might have been to create a 32-bit virtual machine using QEMU KVM. It is quite easy supposedly using virt-manager. I will check it out.

marcelm commented 1 year ago

Another alternative might have been [...]

This was just for fun ... You can use Docker with a 32-bit image instead:

docker run --rm -it i386/debian bash

(64-bit kernels can run 32-bit binaries)

rhpvorderman commented 1 year ago

Ah thanks. that sounds like a lot less work. Good to know.