marcelo-mason / PreciousStones

Self-service protection for Minecraft servers
http://dev.bukkit.org/server-mods/preciousstones/
56 stars 67 forks source link

Preventing accidental facepalms when player cannot read "Sneak place this or it breaks"? #1095

Closed Coldene closed 7 years ago

Coldene commented 7 years ago

Anyone going over closed issues... IF YOU USE SNEAK TO PLACE TRUE, WITH META LORE BLOCKS... ADD THESE FLAGS TOGETHER OR FAIL.

sneak-to-place: true sneak-to-place-only: true

New flag, prevents accidental not sneaking place and break PStone lore/meta. It's.. I like this flag!

Hello and thank you for reading this if you have time. Thanks alot marcelo-mason also for the response to issue 1088 (Increased blockbreak event priority will likely reduce any chance of PS missing a ghost Slimefun block or magically canceled blockbreak event, these were the only suspects in a rare public server crash issue during automatic rollbacks in a grief revert back in 1.10. This event has not happened since then. ;) Sorry for the large post and code snips.

So for quite some time now the custom name and lore of PStones as an option is a brilliant addition. TY! Since then it's noted that once apon a time a player placed a plain diamond PStone block and was not sneaking when that was required, they could just break it and sneak place it np. Now if a player does not sneak when that is a requirement they place the block and it loses all it's meta lore/name info. The pstone breaks. It is also noted even if you laser burn into the retinas of all members of server, every 5 minutes, "Always sneak place your claim or utility stones or they break!" .. they somehow forget, often. It's a massive facepalm generator for staff and players. Forgetting to sneak place. Costly and hits morale, sometimes also. Sneak-to-place: true? I need this for customisation reasons as stated below.

I have 30+ PStone types, 3 full chest menus with buy/sell/controls all players can use. I spent alot of time making them all and integrating them into events, crafts, other plugins, kits. It is sad to see them get pwned by lack of memory... (hah) or inexperienced players forgetting to sneak place. So after some time and some magic all these 30+ stone/utility type claims cannot be placed now unless the player is actually sneaking. It's my own fault for delay in creating these mechanics but up till this point they just broke.

A MagicSpells passive mechanic.

§b⇨§6PSTz6b§r: spell-class: ".PassiveSpell" always-granted: true name: §b⇨§6PSTz6b§r triggers:

The above passive tiny spell is one of a set that stops all players being able to accidentally place all claims or utilities unless they are actually sneaking. The modifier "sneaking" with denied means the passive spell is canceled if they are sneaking, so they can then place it. cancel-default-action: true if they are not sneaking. The target spell MPrvt1 does absolutely nothing but could run any number of commands or all kinds of madness magic.

And? It would be extremely assuring for all servers, staff and players and considerate if precious stones could recognise a player was holding a pstone block and not the plain types and then prevent them from placing it when they are not sneaking if that is a requirement. This would cancel many many many facepalms across the MC metaverse and possibly even increase polularity of the plugin as server owners can then trust it to not bully new and forgetful members breaking thier pstones when they forget to sneak place?

`- title: §7§l■ §f§lFliptable Anti PVP§7§l■§r meta-autoset: false meta-name: §f§lFliptable Laser Pro§r meta-lore:

A custom villager buying a large amount of custom drops for cash tokens also sells the above pstone that has 23 scrollable skills on it, they have to right click to scroll up/down the list of skills on that block while holding it like a wand. There is a high chance of them accidentally placing one because of this. Some of the skills are mad like surround player in cake blocks, give handfulls of FPS destroying super fireworks, levitate players, mobs etc. All PS blocks except foresters have skills on them. They need to click with them to select abilities. MagicSpells is recognising these magically upgraded PS blocks by name and lore. Maybe now you see why sneak-to-place: true is a must for this server? :D

Perhaps even an idea for a future Precious Stones addon that looks up all the info for blocks by meta-name: + meta-lore: and cancels normal placing of those PS blocks if they have sneak-to-place: true

I thank you again for reading. Please consider adding a preventative assurance measure to stop accidental placement of pstones with meta/lore that have sneak place required. For now I think I may have fixed it with Magic...

https://github.com/marcelo-mason/PreciousStones/issues/1084 Someone else appears to have this issue and no doubt many more too embarassed to say! :D

<O Thank you very much for PS 10.7.0, excellent. Current config... https://pastebin.com/mKDk0sG7

essentials /createkit export https://pastebin.com/q6Ciffpx

Coldene commented 7 years ago

fix for sneak-to-place-only for #1095

genius 1. Exceptional intellectual or creative power or other natural ability. 2. An exceptionally intelligent person or one with exceptional skill in a particular area of activity.

synonyms: brilliance, great intelligence, great intellect, great ability, cleverness, brains, erudition, wisdom, sagacity, fine mind, wit, artistry, flair, creative power, precocity, precociousness More

Thank you... stunned

prevent-accidental-facepalms: true

CHECK!

Works great ;)