marcelo-mason / PreciousStones

Self-service protection for Minecraft servers
http://dev.bukkit.org/server-mods/preciousstones/
56 stars 66 forks source link

SimpleClans War #127

Closed gabizou closed 12 years ago

gabizou commented 12 years ago

So from my understanding the use of PreciousStones and SimpleClans is that when two clans are at war, the enemy clan is added to the PreciousStones allow lists (Jack oDeath don't deal damage, City Protection allows them to modify area, Snitch doesn't record them entering etc.)

I really wanted this functionality but even after just running a test server with:

CraftBukkit 1597 SimpleClans 1.9.1 PreciousStones 7.1.0 Vault 1.2.0 iConomy 5.01 (I prefer to have players be able to use /money top and ranking)

So. Here's what I do with those plugins:

I start the server running default perms. Fresh start.

1) Start server 2) Stop server 3) Configure SimpleClans for warring (set it to minimum of 1 player to rival for testing purposes) 4) Start server 5) Testers log in 6) Create Clan A and Clan B and Clan C (wanted to check whether if warring clans can indeed invade regions and bouncers, the other clan that isn't at war wouldn't) 7) Clans create a wall around themselves and place a City Protection (yes, I tested whether the protections were far enough from each other not to interact with each other) 8) Clan A and B rival, then /clan war start ClanATag 9) SimpleClans processes both clans at war and treats them as such. Here's where it misses, either from SC or from the PS side 9) Clan A attempts to dig into Clan B's walls but Clan A can not dig into the walls due to permissions not granted from PreciousStones (this applies to all the protection blocks)

Now I checked whether PS was automatically adding the clans into the allowed list, and yes, PS was setting the clans' members' stones allowed to the clans as well as the member. So in that sense, PS is automatically finding the hook from SC to set the clans in the allowed list for the defending clan.

Just was I understanding the documentation (which is somewhat scattered on BukkitDev and the wiki and the github wiki) that SC clans at war should be allowed into the protections of the PS from the warring clans or are they not supposed to change their protections at all?

gabizou commented 12 years ago

Anything?

marcelo-mason commented 12 years ago

No nothing would need to be done by either side apart form that. Ill check on this later on.

Chrisknyfe commented 12 years ago

I also reproduce this issue with SimpleClans 2.0.2 and PreciousStones 8.0.1, CB 1.1-R3.

polkunus commented 12 years ago

Same here, having same problem.

Chrisknyfe commented 12 years ago

Still reproduced with PreciousStones 8.1.3, SimpleClans 2.0.5, and PermissionsEx 1.18, all on CB 1.1-R3. I've literally tried this on a test server, and wasn't able to get any debug output when placing or destroying a block in the opponent's preciousstone (this is with debug:true in the config.)

This claim in version 8.1.0: "Fixed: War, it is working now" is false. Sorry...

marcelo-mason commented 12 years ago

weird, should be working, ill test agian

polkunus commented 12 years ago

Thank you so much for getting this working

gabizou commented 12 years ago

Verified, issue is resolved with latest versions of PreciousStones and SimpleClans.

Definitely greatly appreciated :)

marcelo-mason commented 12 years ago

Great. np

sandor111 commented 7 years ago

You guys got out off it but for me its still not working?? I just downloaded this plugin and i am using bove latest versions if some one joins my clan he is able to place/destroy block in my ps regions but when i declear war we can't destroy the enemy's base

Meibisu commented 6 years ago

1.11.2 Not Working