search

marceloavf / github-tools-vsts

📦:octocat:🚀 Create and modify GitHub Releases in Azure DevOps Build and Release Management
https://marketplace.visualstudio.com/items?itemName=marcelo-formentao.github-tools
MIT License
24 stars 15 forks source link

fix: update node to 10.17.0 #64

Open DusKing1 opened 2 years ago

DusKing1 commented 2 years ago 
This task uses Node 6 execution handler, which will be deprecated soon. If you are the developer of the task - please consider the migration guideline to Node 10 handler - https://aka.ms/migrateTaskNode10. If you are the user - feel free to reach out to the owners of this task to proceed on migration.

https://github.com/microsoft/azure-pipelines-tasks/blob/master/docs/migrateNode10.md

marceloavf commented 2 years ago

Hi @DusKing1

Thank you for this PR, I think this error is more relatable to this line 222, since it specifies the node version used to run this task in azure devops pipeline agents:

https://github.com/marceloavf/github-tools-vsts/blob/9547d3a3dcfb04f98fa5bcc6ebbc7368ca68d041/Src/GithubReleasePublish/task.json#L221-L226

I was not maintaining this task due to Microsoft contact me because they were creating a native extension to link Azure DevOps to GitHub, but I don't know the progress of it

I would consider releasing this update as a breaking change (v2), since I don't know how this would affect this task and tests don't cover it right now

DusKing1 commented 2 years ago

@marceloavf thank you for your reply! A new release with fix would be nice at the moment since Microsoft hasn't released anything.