search

marcelog / Ding

DI ( Dependency Injection: Setter, Constructor, Method), AOP ( Aspect Oriented Programming ), Events support, xml, yaml, and annotations (including some JSR 250 and JSR 330, like @Configuration and @Bean ala java configuration) , lightweight, simple, and quick MVC ( Model View Controller ), syslog, tcp client and server, with non blocking sockets, custom error, signal, and exception handling through events. Needs PHP 5.3, very similar to seasar, spring ( java ) . Can be deployed as a PHAR file.
http://marcelog.github.com/Ding
Apache License 2.0
121 stars 26 forks source link

Iaejean custom http session #120

Open iaejean opened 10 years ago

iaejean commented 10 years ago

Thanks for your advice and apologize for the delay but I also sent the changes and tests, greetings and I am waiting for your comments.

marcelog commented 10 years ago

The pull looks great :) I'll try to make some final tests. If you take care of the comments that I just wrote, we're ready to merge :) Thanks man!

marcelog commented 10 years ago

Tests don't pass for me. Check the comments. And also, for example for the tests in Test_HttpFrontController the session bean is missing.

Please check that all the tests pass, and let me know. I'm still interested in merging :)

Good luck! Cheers,