search

marcelog / Nami

Asterisk manager interface (ami) client for nodejs
http://marcelog.github.com/Nami
Apache License 2.0
99 stars 59 forks source link

Support for Asterisk 11 #8

Closed joshelson closed 11 years ago

joshelson commented 11 years ago

Asterisk 11 is using AMI 1.3. This one line patch adds at least the beginning of compatibility. Haven't verified 100% of functionality between 10 and 11, but thus far, it appears to work normally.

marcelog commented 11 years ago

Hi Josua,

Thanks for the contribution :)

Just a thing: for the next time, please open the PR from a branch other than master, it should have a meaningful name for the changes, something like "joshua_asterisk_11_support" or similar

Best!

joshelson commented 11 years ago

Yepp... I definitely forgot to do that. Was just trying to do before I forgot.

Thanks Marcelo. Hope you have a great New Year.

J.

On Mon, Dec 31, 2012 at 7:49 AM, Marcelo Gornstein <notifications@github.com

wrote:

Hi Josua,

Thanks for the contribution :)

Just a thing: for the next time, please open the PR from a branch other than master, it should have a meaningful name for the changes, something like "joshua_asterisk_11_support" or similar

Best!

— Reply to this email directly or view it on GitHubhttps://github.com/marcelog/Nami/pull/8#issuecomment-11778295.

marcelog commented 11 years ago

You too! :)