marcelog / PAGI

PHP AGI ( Asterisk Gateway Interface ) facade, with CDR ( Call Detail Record ), Call spool and schedule auto dial, Send and Receive Fax, Channel Variables, and Caller ID management
http://marcelog.github.com/PAGI
Apache License 2.0
191 stars 76 forks source link

Changed the log4php requirement source from pear to composer/packagist #19

Closed staelche closed 10 years ago

staelche commented 10 years ago

Use native composer package of log4php (since it is available) instead of using the pear package

marcelog commented 10 years ago

hey, cool :) shouldn't we also update composer.lock in this same pull request?

staelche commented 10 years ago

Mh. Since you checked it in. Yes.

I didn't realize the .lock file since i don't check it in for my projects. That is because the lock file reflects only the actually selected library versions of the projects requirements. You did the statment in your composer.json that every log4php >= 2.1.0 in fine. In the end you lock projects based on PAGI down to version 2.1.0 since they use the lock file for installing the requirements. Then you could have added the log4php lib only in version 2.1.0 to the project (composer.json) and you would not need the lock file anymore.

2 choices and your decision (I'll do the work):

After writing this only the first option would make sense to me...

Reference/Discussions:

marcelog commented 10 years ago

Agreed, @staelche, let's go with #1 :)

marcelog commented 10 years ago

thanks man! :) never liked that pear repository there :)

staelche commented 10 years ago

Welcome