marcelog / logger_logstash_backend

Logstash backend for the Elixir Logger

Apache License 2.0

73 stars 40 forks source link

Inspect all field values that are pids #6

Closed KronicDeth closed 8 years ago

KronicDeth commented 8 years ago

Changelog

Bug Fixes

Previously, only the pid key of the metadata would be inspected before being passed as the fields value of the map that is encoded by JSX.encode, but a pid can appear in other fields, so all field values are now escaped with inspect if they are pids. This prevents a MatchError happening because JSX.encode would return {:error, :badarg} if it tried to encode a pid.

marcelog commented 8 years ago

Hello!

Thanks for the pull!

I'm curious about why this is needed. When you say "but pid can appear in other fields", why is that exactly? Are those fields being filled by Elixir or Logger itself somehow?

KronicDeth commented 8 years ago

It can happen in Phoenix with :ecto_conn_pid.

marcelog commented 8 years ago

Got it! Thanks :)