search

marceloschmitt / moodle-block_analytics_graphs

Learning analytics Moodle plugin - graphs to help teachers.
GNU General Public License v3.0
15 stars 17 forks source link

More Turnitin additions (and minor fix) #20

Closed benchen71 closed 7 years ago

benchen71 commented 7 years ago

Minor fix in timeaccesschart.php is checking for no students enrolled in course and exiting if none. (So sorry, but looking at my changes below, it seems I have inadvertently reverted some of your whitespace changes. I hope that isn't a major problem!)

marceloschmitt commented 7 years ago

Ok, Ben. I am just making the code error free when someone test it with codechecker. As soon as I finish it, I will make this version the production version.

benchen71 commented 7 years ago

Sounds great! I have no more changes at the moment.

marceloschmitt commented 7 years ago

Ben, I have made your changes manually. I will close your request. Please test it.

benchen71 commented 7 years ago

Hi Marcelo,

I made some minor changes to lib.php and made a pull request.

Sincerely, Ben.

On Wed, 28 Jun 2017 at 22:44 Marcelo A. Rauh Schmitt < notifications@github.com> wrote:

Ben, I have made your changes manually. I will close your request. Please test it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/marceloschmitt/moodle-block_analytics_graphs/pull/20#issuecomment-311648661, or mute the thread https://github.com/notifications/unsubscribe-auth/AFxh7U9rJNIw-GV9BFT2tQBq8B9z3ZPFks5sIkqrgaJpZM4ODAuR .