search

marcelotduarte / cx_Freeze

cx_Freeze creates standalone executables from Python scripts, with the same performance, is cross-platform and should work on any platform that Python itself works on.
https://marcelotduarte.github.io/cx_Freeze/
Other
1.28k stars 210 forks source link

hooks: fix #2382 regression / improve tests and docs #2443

Closed marcelotduarte closed 1 week ago

marcelotduarte commented 2 weeks ago

Closes #2435 Closes #2433

2376

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.77%. Comparing base (c3b273e) to head (6e80828).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2443 +/- ## ======================================= Coverage 79.77% 79.77% ======================================= Files 27 27 Lines 4089 4089 ======================================= Hits 3262 3262 Misses 827 827 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcelotduarte commented 2 weeks ago

Please do a test without freeze_support so you can see the message (before it was in a loop).

ntindle commented 2 weeks ago

Won't be able to test today unfortunately, Just realized its almost 1am

ntindle commented 2 weeks ago

Works on windows

ntindle commented 2 weeks ago

testing mac next

ntindle commented 2 weeks ago

On mac, when commenting out multiprocessing.freeze_support() 5 of the 7 multiprocessing tests still pass With the freeze_support enabled, all tests pass.

The failing tests are sample1-spawn and sample2-spawn. They fail in expected ways. The passing tests have no output but that may be a config issue on my side (or false passes)

marcelotduarte commented 2 weeks ago

The failing tests are sample1-spawn and sample2-spawn. They fail in expected ways.

They fail but do not enter an infinite loop as before, right?

ntindle commented 2 weeks ago

Correct