marcelotduarte / cx_Freeze

cx_Freeze creates standalone executables from Python scripts, with the same performance, is cross-platform and should work on any platform that Python itself works on.
https://marcelotduarte.github.io/cx_Freeze/
Other
1.28k stars 210 forks source link

bdist_rpm: Fix string concat error due to order of op for + and or in RPM #2444

Closed ntindle closed 2 weeks ago

ntindle commented 2 weeks ago

Background

When running an rpm build, if you don't have self.distribution.get_description populated, cx_Freeze should use 'UNKNOWN'. However, due to an order of operations bug, it attempts to concat str with None which isn't possible

Changes

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.77%. Comparing base (406dc8b) to head (04dee2d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2444 +/- ## ======================================= Coverage 79.77% 79.77% ======================================= Files 27 27 Lines 4089 4089 ======================================= Hits 3262 3262 Misses 827 827 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcelotduarte commented 2 weeks ago

Thanks!