search

marcelotduarte / cx_Freeze

cx_Freeze creates standalone executables from Python scripts, with the same performance, is cross-platform and should work on any platform that Python itself works on.
https://marcelotduarte.github.io/cx_Freeze/
Other
1.28k stars 210 forks source link

Add license for msi #2472

Open ntindle opened 1 week ago

ntindle commented 1 week ago

Background

The current bdist_msi command does not support a license confirmation page

Changes

This PR

marcelotduarte commented 1 week ago

I'm trying to understand why the failures with codecov: info - 2024-06-21 07:25:41,467 -- The PR is happening in a forked repo. Using tokenless upload. Error: Codecov token not found. Please provide Codecov token with -t flag.

ntindle commented 1 week ago

code cov requires a token to upload coverage.

The tokens aren’t available on the pull_request push trigger in GitHub actions

not sure how we got around this at AutoGPT. I think installing the code cov app into the org or repo was it though. Can look more if desired

marcelotduarte commented 1 week ago

According to the information in the links below, you would not need the token. https://github.com/marketplace/actions/codecov#breaking-changes https://docs.codecov.com/docs/frequently-asked-questions#where-is-the-repository-upload-token-found

marcelotduarte commented 1 week ago

not sure how we got around this at AutoGPT. I think installing the code cov app into the org or repo was it though. Can look more if desired

This has already been done and was working well. It had happened to another PR, which is still open and is happening to yours. When I modify, or rebase, they pass.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 80.02%. Comparing base (dd53073) to head (c4a4a06). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2472 +/- ## ========================================== + Coverage 79.88% 80.02% +0.14% ========================================== Files 27 27 Lines 4091 4111 +20 ========================================== + Hits 3268 3290 +22 + Misses 823 821 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.