search

marcelpinto / RxFlux

RxFlux is a small framework in order to follow Flux design pattern with RxJava functionalities
Apache License 2.0
326 stars 38 forks source link

classCastException - onActivity destroyed #17

Closed RasmusKOlsen closed 8 years ago

RasmusKOlsen commented 8 years ago

Hi,

I am getting a ClassCastException due to onDestory in RxFlux not checking instanceof before casting (line 112). It seems there is already a pull request that fixes this issue(https://github.com/skimarxall/RxFlux/pull/12), and it appears to be merged - however it is not part of the 0.3.2 release.

marcelpinto commented 8 years ago

Yes I'll try to merge it with the rest and make a release ASAP.

On Tue, 17 May 2016, 16:04 Rasmus Olsen, notifications@github.com wrote:

Hi,

I am getting a ClassCastException due to onDestory in RxFlux not checking instanceof being casting (line 112). It seems there is already a pull request that fixes this issue(#12 https://github.com/skimarxall/RxFlux/pull/12), and it appears to be merged - however it is not part of the 0.3.2 release.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/skimarxall/RxFlux/issues/17

marcelpinto commented 8 years ago

done